fix: node gateway visbility improvements

internal/jsonrpc/jsonrpc.go

@@ -102,14 +102,14 @@ type DecodeError struct {
 	Content []byte // Content that couldn't be decoded.
 }
 
-func NewDecodeError(err error, content []byte) DecodeError {
-	return DecodeError{
+func NewDecodeError(err error, content []byte) *DecodeError {
+	return &DecodeError{
 		Err:     err,
 		Content: content,
 	}
 }
 
-func (e DecodeError) Error() string {
+func (e *DecodeError) Error() string {
 	return fmt.Sprintf("decode error: %s, content: %s", e.Err.Error(), string(e.Content))
 }
 

internal/jsonrpc/jsonrpc_test.go

@@ -143,6 +143,11 @@ func TestEncodeAndDecodeResponses(t *testing.T) {
 				},
 			},
 		},
+		{
+			testName:         "empty response in batch",
+			body:             ``,
+			expectedResponse: nil,
+		},
 		{
 			testName: "batch responses",
 			body: "[" +
@@ -180,9 +185,11 @@ func TestEncodeAndDecodeResponses(t *testing.T) {
 		assert.Nil(t, err)
 		assert.Equal(t, tc.expectedResponse, decoded)
 
-		encoded, err := decoded.Encode()
+		if decoded != nil {
+			encoded, err := decoded.Encode()
 
-		assert.Nil(t, err)
-		assert.Equal(t, tc.body, string(encoded))
+			assert.Nil(t, err)
+			assert.Equal(t, tc.body, string(encoded))
+		}
 	}
 }

internal/metrics/metrics.go

@@ -94,7 +94,7 @@ var (
 				"Batches are deconstructed to single JSON RPC requests for this metric.",
 		},
 		// jsonrpc_method is "batch" for batch requests
-		[]string{"chain_name", "client", "upstream_id", "url", "jsonrpc_method", "response_code", "jsonrpc_error_code"},
+		[]string{"chain_name", "client", "upstream_id", "url", "jsonrpc_method", "jsonrpc_error_code"},
 	)
 
 	upstreamRPCDuration = promauto.NewHistogramVec(