Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to pass more props to text widget #727

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vasilich6107
Copy link
Contributor

@vasilich6107 vasilich6107 commented Dec 13, 2024

Currently we have an ability to pass through textAlign: widget.decoratorProps.textAlign, property.

This PR adds an ability to pass all props supported by Text widget

Copy link
Owner

@salim-lachdhaf salim-lachdhaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the added properties are not an InputDecorator props.

imho, you should add a new props named TextProps which contains all text props.

and make two _getBaseTextStyle one for InputDecorator and another for Text (because you will have two TextStyle).

and you can add here the modification (DefaultTextStyle) made on #719 after changing copyWith with merge (same behavior as now).

@vasilich6107
Copy link
Contributor Author

Makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants