Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/propagate text style via default text style #719

Conversation

vasilich6107
Copy link
Contributor

@vasilich6107 vasilich6107 commented Dec 5, 2024

Hi @salim-lachdhaf

This PR i mainly focuses on changing the mechanism of text style propagation and adds more text props

For example - currently there is no way to define maxLines(only textAlign is available)

In addition to that if you define dropdownBuilder - we are loosing all props previously defined in decoratorPorps(cause it just renders as is) and we have to reproduce calculation of textStyle based on disabled prop

image

@vasilich6107 vasilich6107 force-pushed the feature/propagate-text-style-via-default-text-style branch from 1e66fe1 to 2e82d25 Compare December 5, 2024 10:35
@vasilich6107
Copy link
Contributor Author

also fixes

#720

@vasilich6107
Copy link
Contributor Author

also fixes #722

@salim-lachdhaf
Copy link
Owner

Maybe we can update this approach to merge the styles instead of copyWith . This way, the existing theme or customizations can seamlessly integrate without forcing a specific style.

@salim-lachdhaf
Copy link
Owner

continued on #727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants