Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated info to add PGN mainnet and testnet #315

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Updated info to add PGN mainnet and testnet #315

merged 1 commit into from
Nov 6, 2023

Conversation

sodofi
Copy link
Contributor

@sodofi sodofi commented Nov 2, 2023 •
edited
Loading

Corrected the addresses. Please let me know if this needs updating or if there is more information needed from PGN.

@sodofi sodofi requested review from a team as code owners November 2, 2023 17:15
mmv08
mmv08 requested changes Nov 2, 2023
View reviewed changes
.history/src/assets/v1.3.0/compatibility_fallback_handler_20231102170232.json Outdated
@@ -0,0 +1,478 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are those files? Please remove them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were removed

src/assets/v1.3.0/compatibility_fallback_handler.json Outdated
@@ -123,6 +124,7 @@
"54211": "0x017062a1dE2FE6b99BE3d9d37841FeD19F573804",
"56288": "0x017062a1dE2FE6b99BE3d9d37841FeD19F573804",
"57000": "0x017062a1dE2FE6b99BE3d9d37841FeD19F573804",
"58008": "0x1AC114C2099aFAf5261731655Dc6c306bFcd4Dbd",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this address doesn't match the expect address

src/assets/v1.3.0/sign_message_lib.json Outdated
@@ -51,6 +51,7 @@
"336": "0xA65387F16B013cf2Af4605Ad8aA5ec25a2cbA3a2",
"338": "0x98FFBBF51bb33A056B08ddf711f289936AafF717",
"420": "0x98FFBBF51bb33A056B08ddf711f289936AafF717",
"424": "0x7cbB62EaA69F79e6873cD1ecB2392971036cFAa4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This address doesn't match the expected one

@sodofi
Copy link
Contributor Author

sodofi commented Nov 6, 2023

@mmv08

Fixed PR so that .history files are removed, and mainnet contracts match expected addresses.

Additionally, removed testnet for now since some of the contracts aren't verified on PGNs end.

@mmv08
Copy link
Member

mmv08 commented Nov 6, 2023

Additionally, removed testnet for now since some of the contracts aren't verified on PGNs end.

It is still present in one of the files. Also, it's okay with us if the contract isn't verified since the deployment is deterministic and depends on the hash of the bytecode. If one were to alter the code, it would result in a different address.
https://github.com/safe-global/safe-deployments/pull/315/files#diff-905275e3e6a99d588ff498e27b13efa9ee12d1ae314645f224cecca748ed98feR126

@sodofi sodofi mentioned this pull request Nov 6, 2023
Open
@sodofi
Copy link
Contributor Author

sodofi commented Nov 6, 2023

@mmv08 Just added back testnet with expected contract addresses.

Is there more we need to ensure is done on the PGN side to ensure this PR gets merged?

@mmv08 mmv08 merged commit 2c5b36c into safe-global:main Nov 6, 2023
1 check passed
@bertux bertux mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmv08 mmv08 mmv08 approved these changes

@rmeissner rmeissner Awaiting requested review from rmeissner rmeissner is a code owner automatically assigned from safe-global/safe-protocol

@nlordell nlordell Awaiting requested review from nlordell nlordell is a code owner automatically assigned from safe-global/safe-protocol

@akshay-ap akshay-ap Awaiting requested review from akshay-ap akshay-ap is a code owner automatically assigned from safe-global/safe-protocol

@fmrsabino fmrsabino Awaiting requested review from fmrsabino fmrsabino was automatically assigned from safe-global/safe-services

@Uxio0 Uxio0 Awaiting requested review from Uxio0 Uxio0 was automatically assigned from safe-global/safe-services

@iamacook iamacook Awaiting requested review from iamacook iamacook was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sodofi @mmv08