Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add PGN Mainnet+Testnet and Arthera Testnet 1.3.0 L2 contracts #682

Merged
merged 5 commits into from
Dec 12, 2023
Merged

feat: add PGN Mainnet+Testnet and Arthera Testnet 1.3.0 L2 contracts #682

merged 5 commits into from
Dec 12, 2023

Conversation

bertux
Copy link
Contributor

@bertux bertux commented Nov 9, 2023 •
edited
Loading

Please add PGN Mainnet+Testnet and Arthera Testnet based on:
safe-global/safe-deployments#315 done by @Sodew for PGN
safe-global/safe-deployments#329 in review for Arthera
Thank you!

@bertux bertux requested a review from a team as a code owner November 9, 2023 16:33
@bertux bertux requested review from fmrsabino, moisses89 and iamacook and removed request for a team November 9, 2023 16:33
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@bertux
Copy link
Contributor Author

bertux commented Nov 9, 2023

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Nov 9, 2023
@github-actions
@bertux has signed the CLA in #682
57af65a
@bertux bertux force-pushed the pgn-arthera branch 2 times, most recently from 372c93e to 52cff61 Compare November 9, 2023 16:52
moisses89
moisses89 requested changes Nov 14, 2023
View reviewed changes
gnosis/safe/addresses.py
@@ -595,6 +595,12 @@
("0x3E5c63644E683549055b9Be8653de26E0B4CD36E", 2362236, "1.3.0+L2"),
("0xd9Db270c1B5E3Bd161E8c8503c55cEABeE709552", 2362238, "1.3.0"),
],
EthereumNetwork.PGN_MAINNET: [
("0x3E5c63644E683549055b9Be8653de26E0B4CD36E", 344345, "1.3.0+L2"),
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.3.0 contract was not deployed there? 0x3E5c63644E683549055b9Be8653de26E0B4CD36E

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've followed the README instructions, and from what I understood I should only fill 1.3.0 L2 version contract address and not 1.3.0 contract address.
So it seems I misunderstood, I will add the 1.3.0 contract address too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moisses89 added 1.3.0 contract

gnosis/eth/ethereum_network.py Outdated
@@ -736,6 +736,9 @@ class EthereumNetwork(Enum):
ZENIQ = 383414847825
PDC_MAINNET = 666301171999
MOLEREUM_NETWORK = 6022140761023
PGN_MAINNET = 424
PGN_TESTNET = 58008
ARTHERA_TESTNET = 10243
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be sorted by chain_id.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moisses89 sorted by chain_id

@sodofi
Copy link
Contributor

sodofi commented Nov 27, 2023

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Nov 27, 2023
@github-actions
@Sodew has signed the CLA in #682
200012c
@sodofi
Copy link
Contributor

sodofi commented Nov 27, 2023

Changes fixed. Please review @moisses89

@bertux bertux requested a review from moisses89 November 27, 2023 17:05
@bertux bertux changed the title feat: add PGN Mainnet and Testnet 1.3.0 L2 contracts feat: add PGN Mainnet+Testnet and Arthera Testnet 1.3.0 L2 contracts Nov 27, 2023
moisses89
moisses89 previously approved these changes Dec 11, 2023
View reviewed changes
@moisses89 moisses89 dismissed their stale review December 11, 2023 14:37

Blocked to merge

@moisses89
Copy link
Member

This PR should be merged first safe-global/safe-deployments#329

@bertux bertux mentioned this pull request Dec 11, 2023
Merged
@moisses89 moisses89 merged commit 981485f into safe-global:master Dec 12, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
@bertux bertux deleted the pgn-arthera branch December 14, 2023 11:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sodofi sodofi sodofi left review comments

@moisses89 moisses89 moisses89 approved these changes

@fmrsabino fmrsabino Awaiting requested review from fmrsabino fmrsabino was automatically assigned from safe-global/safe-services

@iamacook iamacook Awaiting requested review from iamacook iamacook was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bertux @sodofi @moisses89