-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rust-toolchain.toml
to raytracing example
#3607
Conversation
rust-toolchain.toml
to raytracing example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing because of the toolchain file.
I just took a quick look at the documentation to see if there is some flag to ignore it but couldn't really find anything. Would you mind exploring what to do here?
A quick solution that comes to mind here is to just use +stable
to override the toolchain file.
Okay, I do think the clippy CI run needs to either install a nightly version of clippy, or it needs to change the command from |
I'm in favor of that. |
197555d
to
5adf341
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
The raytracing example requires a nightly build of Rust, and the source code to the Rust std library.
Running
build.sh
while your stable toolchain is active will result in an error:I tried changing
build.sh
to runcargo +nightly
, but this broke CI.My inclination here is to describe these dependencies with a toolchain file. It's one less build flag to forget.