-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples/raytrace-parallel] Replace Bash with Python for Windows compatibility #3603
Conversation
d9a8d65
to
b90a925
Compare
5870d05
to
874d314
Compare
I would be fine with it since the server is already in Python. Though I dislike that we are using shell scripts or Python at all here. Considering all this stuff needs nightly anyway, maybe we could use cargo scripts instead? Though this LGTM, I'm not familiar with Python, so another maintainer should have a look at this. |
874d314
to
5350848
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wasm-audio-worklet
's README should also be updated.
9faf55f
to
a890159
Compare
a890159
to
69a1e6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to get this example running on my Windows machine without fiddling with Powershell environment variables, so I just rewrote the shell scripts as Python scripts.
Since this example already requires you to have a Python3 installation, this PR makes the example work cross-platform without introducing a new dependency on Python3.
It looks like CI has some dependency on
build.sh
existing, so I just made it redirect tobuild.py
. That may make any error messages look a bit less friendly in CI, since they'll be Python tracebacks😥 I'll let you decide if this is worth the tradeoff!