fix: do not offer completions within macro strings #18832
Merged
+72
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
vishruth-thimmaiah
force-pushed
the
fix_string_comp
branch
2 times, most recently
from
54a3002 to
314c82a
Compare
|
Please add a test. You can look at existing tests in https://github.com/rust-lang/rust-analyzer/tree/master/crates/ide-completion/src/tests. |
vishruth-thimmaiah
force-pushed
the
fix_string_comp
branch
from
314c82a to
6780275
Compare
Veykril
reviewed
Jan 6, 2025
vishruth-thimmaiah
force-pushed
the
fix_string_comp
branch
from
6780275 to
cb0221d
Compare
ChayimFriedman2
requested changes
Jan 7, 2025
ChayimFriedman2
approved these changes
Jan 7, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17479
This PR disables completions within strings in proc macros.