Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken env!("") macro environment variable suggestions in VSCode #18883

Closed
Maksych opened this issue Jan 8, 2025 · 5 comments · Fixed by #18884
Closed

Broken env!("") macro environment variable suggestions in VSCode #18883

Maksych opened this issue Jan 8, 2025 · 5 comments · Fixed by #18884
Labels
C-bug Category: bug

Comments

@Maksych
Copy link

Maksych commented Jan 8, 2025

rust-analyzer version: 0.3.2257-standalone (238ccb6 2025-01-08)

rustc version: rustc 1.83.0 (90b35a623 2024-11-26)

editor or extension: VSCode

relevant settings: default

code snippet to reproduce:
In VSCode, when you write env!("") and move the cursor between the quotes, you can press Option + Esc to open suggestions that should show possible environment variables. This used to work, but now it doesn't.
Image

For example this work in Zed:
Image

@Maksych Maksych added the C-bug Category: bug label Jan 8, 2025
@lnicola
Copy link
Member

lnicola commented Jan 8, 2025

Is this #18832?

@Maksych Maksych closed this as completed Jan 8, 2025
@lnicola lnicola reopened this Jan 8, 2025
@Maksych
Copy link
Author

Maksych commented Jan 8, 2025

@lnicola why repopen?
Do you think it's not duplicate?

@lnicola
Copy link
Member

lnicola commented Jan 8, 2025

It might have been caused by that PR, I'll have to test.

@Veykril
Copy link
Member

Veykril commented Jan 8, 2025

It's most likely that one, though odd that it didn't fail the tests

@Veykril
Copy link
Member

Veykril commented Jan 8, 2025

No the issue is actually something entirely different (I think this broke quite a long time ago? blame would imply 10 months)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants