Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing aput in awrite_response_to_history #17338

Merged
merged 6 commits into from
Dec 20, 2024
Merged

Fix missing aput in awrite_response_to_history #17338

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
24ceab5
fix: invalid chunk when streaming
Nov 29, 2023
f0e4ea3
edit condition order
Nov 29, 2023
bde18a9
Merge remote-tracking branch 'upstream/main'
Dec 20, 2024
68b1e94
Add missing await for new aput
Dec 20, 2024
d3aa7ec
Rm local leftovers
Dec 20, 2024
3ae25b3
Rm local leftovers
Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llama-index-core/llama_index/core/chat_engine/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ async def awrite_response_to_history(
# NOTE: this is to handle the special case where we consume some of the
# chat stream, but not all of it (e.g. in react agent)
chat.message.content = final_text.strip() # final message
memory.put(chat.message)
await memory.aput(chat.message)
except Exception as e:
dispatcher.event(StreamChatErrorEvent(exception=e))
self.exception = e
Expand Down
Loading