Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing aput in awrite_response_to_history #17338

Merged
merged 6 commits into from
Dec 20, 2024

Conversation

mathematisse
Copy link
Contributor

@mathematisse mathematisse commented Dec 20, 2024

Description

This adds a missing await / aput in the awrite_response_to_history from the StreamingAgentChatResponse class.

async aput has been introduced with #16127 but the use of aput was missing from that chat engine function

Type of Change

  • [ ✓] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • [ ✓] I believe this change is already covered by existing unit tests

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 20, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 20, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) December 20, 2024 15:50
@logan-markewich logan-markewich merged commit 9750a05 into run-llama:main Dec 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants