Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integration on pinecone hosted rerankers #17192

Merged
merged 11 commits into from
Dec 9, 2024

Conversation

jzhao62
Copy link
Contributor

@jzhao62 jzhao62 commented Dec 8, 2024

Description

  • support 3 rerank model hosted by pinecone-inference-model

  • pinecone managed bge

  • pinecone managed cohere

  • pinecone managed native rerank algo

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No
    image

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 8, 2024
@jzhao62 jzhao62 changed the title support postprocessing rerank from models hosted by pinecone support node post processing using rerankmodels hosted by pinecone Dec 8, 2024
@jzhao62 jzhao62 marked this pull request as draft December 8, 2024 00:16
@jzhao62 jzhao62 marked this pull request as ready for review December 8, 2024 05:47
@jzhao62 jzhao62 changed the title support node post processing using rerankmodels hosted by pinecone feat: integration on pinecone hosted rerankers Dec 8, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 9, 2024
@logan-markewich logan-markewich merged commit 7b2fd72 into run-llama:main Dec 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants