Add timezone support for dates package #59
Conversation
|
Please add documentation that describes how the feature works to DatesProvider page |
i allready added the setting to the datesprovider docs, but if you think a separate section is needed, i will add it. i just added it the same way as the other settings, and i thought this will be fine, as other settings like `locale? also don't have a separate section. I just can't test the docs as i can't get them running on my machines (mac/windows) |
|
@rtivital any idea why the tests are failing? that are all files that are not scope of this MR, are the tests failing in master branch? |
docs/pages/dates/dates-provider.mdx
Outdated
| @@ -12,5 +12,6 @@ components exported from `@mantine/dates` package. `DatesProvider` supports the | |||
| - `locale` – dayjs locale, note that you also need to import corresponding locale module from dayjs. Default value is `en`. | |||
| - `firstDayOfWeek` – number from 0 to 6, where 0 is Sunday and 6 is Saturday. Default value is 1 – Monday. | |||
| - `weekendDays` – an array of numbers from 0 to 6, where 0 is Sunday and 6 is Saturday. Default value is `[0, 6]` – Saturday and Sunday. | |||
| - `timezone` – a string providing the timezone. i.e. `UTC` | |||
There was a problem hiding this comment.
The description is not clear, please update the description so that it contains answers to the following questions:
- Is it applied to all components?
- Is the user supposed to pass the date with timezone information?
- What happens when the user passes a date that has a different timezone as a value to the component?
- What is the default value?
I think this option requires a separate section in this documentation that will describe how it works in details.
There was a problem hiding this comment.
i added some docs, i hope that fits the needs
- Is it applied to all components? -> docs added
- Is the user supposed to pass the date with timezone information? some docs added, but the user cant provide it as you can still only provide a js Date object which doesn't have timezone support
- What happens when the user passes a date that has a different timezone as a value to the component? user cant provide it as you can still only provide a js Date object which doesn't have timezone support
- What is the default value? -> docs added
i hope the docs work as provided (as i can't get them running and so i have no chance of testing them)
|
I'll check the issue with tests tomorrow |
|
@rtivital do you still need something for this MR? |
|
No, I think it's fine |
|
Thanks! |
Addresses mantinedev/mantine#3432
I added a timezone setting to the
DatesProvider, allowing to shift the dates for the components using it. Dates are shifted back and forth by the parent component. It is also used in some helper functions as needed.It is a bit hacky but the only possible solution to not introduce breaking changes.