Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

New @mantine/dates build seams to be incorrect (wrong build) #65

Open
wuifdesign opened this issue Sep 17, 2023 · 5 comments
Open

New @mantine/dates build seams to be incorrect (wrong build) #65

wuifdesign opened this issue Sep 17, 2023 · 5 comments

Comments

@wuifdesign
Copy link
Contributor

wuifdesign commented Sep 17, 2023

What package has an issue

@mantine/dates

Describe the bug

@rtivital it seams that the merge/build is somewhat strange for the timezones introduced with #59, is there something i can fix?

For example:
https://github.com/mantinedev/mantine-v7/blob/172763983b1ae8eb6b4e46a12d0f679c93be923e/src/mantine-dates/src/components/DateTimePicker/DateTimePicker.tsx#L132-L137

it seams to be translated to:

const [_value, setValue] = useUncontrolled({
    value,
    defaultValue,
    finalValue: null,
    onChange
});

you can see it in npm code view: https://www.npmjs.com/package/@mantine/dates/v/7.0.0-beta.7?activeTab=code

Seams likte the changes made by the MR are not in the build.

Running the build locally outputs the correct files.

What version of @mantine/* page do you have in package.json? (Note that all @mantine/* packages must have the same version in order to work correctly)

7.0.0-beta.7

If possible, please include a link to a codesandbox with the reproduced problem

No response

Do you know how to fix the issue

No

Are you willing to participate in fixing this issue and create a pull request with the fix

Yes

Possible fix

No response

@wuifdesign wuifdesign changed the title New timezone build seams to be incorrect New timezone build seams to be incorrect (wrong build) Sep 18, 2023
@rtivital
Copy link
Owner

Your changes were merged, if you think that there are issue, you can sibmit a PR with a fix

@wuifdesign
Copy link
Contributor Author

wuifdesign commented Sep 18, 2023

i don't know how to submit a PR for this. as the MR is working, but the build seams wrong, the al the changes done by the MR are just missing in the @mantine/[email protected] (and also beta.6) build (but present in the source code).

it doesn't seam to be something with the code but more with build/deployment to npm. the build files just not represent the source code. @rtivital

other example:
https://github.com/mantinedev/mantine-v7/blob/83547884342c2c6c3f11ff97eb5c447188c064c7/src/mantine-dates/src/components/DatesProvider/use-dates-context.ts#L6-L17

Bildschirmfoto 2023-09-18 um 11 46 23

the published files are just incorrect (old).

@wuifdesign
Copy link
Contributor Author

wuifdesign commented Sep 18, 2023

@wuifdesign wuifdesign changed the title New timezone build seams to be incorrect (wrong build) New @mantine/dates build seams to be incorrect (wrong build) Sep 18, 2023
@rtivital
Copy link
Owner

I fixed the bug

@wuifdesign
Copy link
Contributor Author

thx :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants