This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
New @mantine/dates build seams to be incorrect (wrong build) #65
Comments
wuifdesign
changed the title
New timezone build seams to be incorrect
New timezone build seams to be incorrect (wrong build)
Sep 18, 2023
Your changes were merged, if you think that there are issue, you can sibmit a PR with a fix |
i don't know how to submit a PR for this. as the MR is working, but the build seams wrong, the al the changes done by the MR are just missing in the @mantine/[email protected] (and also beta.6) build (but present in the source code). it doesn't seam to be something with the code but more with build/deployment to npm. the build files just not represent the source code. @rtivital the published files are just incorrect (old). |
@rtivital other changes are missing too, also some of you. i.e: |
wuifdesign
changed the title
New timezone build seams to be incorrect (wrong build)
New @mantine/dates build seams to be incorrect (wrong build)
Sep 18, 2023
I fixed the bug |
thx :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What package has an issue
@mantine/dates
Describe the bug
@rtivital it seams that the merge/build is somewhat strange for the timezones introduced with #59, is there something i can fix?
For example:
https://github.com/mantinedev/mantine-v7/blob/172763983b1ae8eb6b4e46a12d0f679c93be923e/src/mantine-dates/src/components/DateTimePicker/DateTimePicker.tsx#L132-L137
it seams to be translated to:
you can see it in npm code view: https://www.npmjs.com/package/@mantine/dates/v/7.0.0-beta.7?activeTab=code
Seams likte the changes made by the MR are not in the build.
Running the build locally outputs the correct files.
What version of @mantine/* page do you have in package.json? (Note that all @mantine/* packages must have the same version in order to work correctly)
7.0.0-beta.7
If possible, please include a link to a codesandbox with the reproduced problem
No response
Do you know how to fix the issue
No
Are you willing to participate in fixing this issue and create a pull request with the fix
Yes
Possible fix
No response
The text was updated successfully, but these errors were encountered: