Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-137: Unnecessary domain separator #19

Merged
merged 4 commits into from
Jun 28, 2022
Merged

PP-137: Unnecessary domain separator #19

merged 4 commits into from
Jun 28, 2022

Conversation

antomor
Copy link
Collaborator

@antomor antomor commented Jun 28, 2022

What

  • Modify some types and functions in order to avoid passing the domain separator as part of the request.

Why

  • This extra and unnecessary field makes the operation more expensive.

Refs

@antomor antomor mentioned this pull request Jun 28, 2022
Closed
@antomor antomor merged commit 53ddd2c into master Jun 28, 2022
@antomor antomor deleted the PP-137/unnecessary-domain-separator branch June 28, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndresQuijano AndresQuijano AndresQuijano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antomor @AndresQuijano