Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-137/Unnecessary domainSeparator field in Request #18

Closed
wants to merge 0 commits into from
Closed

PP-137/Unnecessary domainSeparator field in Request #18

wants to merge 0 commits into from

Conversation

AndresQuijano
Copy link
Contributor

@AndresQuijano AndresQuijano commented Jun 16, 2022 •
edited by antomor
Loading

What

  • Modifiy some types and functions in order to avoid passing the domain separator as part of the request.

Why

  • This extra and unnecessary field makes the operation more expensive.

Refs

antomor
antomor approved these changes Jun 28, 2022
View reviewed changes
Copy link
Collaborator

@antomor antomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antomor antomor closed this Jun 28, 2022
@antomor
Copy link
Collaborator

antomor commented Jun 28, 2022

Close in favor of #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antomor antomor antomor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndresQuijano @antomor