Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unblock builds of Nav2 on RHEL 9 #289

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Unblock builds of Nav2 on RHEL 9 #289

merged 1 commit into from
Nov 2, 2023

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Nov 2, 2023

This reverts part of #285

xtensor was made available in RHEL 9 with ros/rosdistro#38843.

There are quite a few packages here, and I expect that some of them will need to reappear on this list for one reason or another, but the fastest and most reliable way to find out which ones fail to build is to try.

cc: @SteveMacenski

This reverts part of commit 027f596.
Copy link

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this, but we should wait for @SteveMacenski 's buy-in since he'll be the one getting the emails.

@SteveMacenski
Copy link

I've not heard any complaints from folks about RHEL not containing binaries of Nav2. However, its not that much overhead to check some emails and follow up here to blacklist the ones that cause problems, so I'm OK with it.

@cottsay
Copy link
Member Author

cottsay commented Nov 2, 2023

Maintainer E-mails are still disabled for RHEL. You won't get anything new. I've been doing most of the package triage for RHEL myself.

@cottsay cottsay merged commit 1e13ea3 into ros2 Nov 2, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cottsay/nav2-rpms branch November 2, 2023 19:30
@cottsay
Copy link
Member Author

cottsay commented Nov 3, 2023

Following up here:

As a result of this change:

  • 44 packages were unblocked and built successfully (33 listed here, 11 dependents of those listed here)
  • 5 packages from this list automatically remained disabled due to listed upstream dependencies
  • 1 package failed to build (0 listed here, 1 dependents of those listed here)
    • I'll note that the failure is rtabmap_slam, which also has a 50% failure rate on Jammy due to linking resource demands

So I take back what I said - nothing removed here need reappear. I'll call it a testament to the quality of navigation2 code and our approach to inter-platform packaging :)

@SteveMacenski
Copy link

What in nav2 depends on rtabmap?

@cottsay
Copy link
Member Author

cottsay commented Nov 3, 2023

What in nav2 depends on rtabmap?

My fault, I meant "downstream dependencies" or "dependents" of Nav2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants