Fix issue #945 #961
Open
Fix issue #945 #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sukhvansh2004 <[email protected]>
|
@Sukhvansh2004 thanks for the PR. i think you are still working on this, right? please let me know once it is ready to review, and DCO is missing. |
Sukhvansh2004
force-pushed
the
rolling
branch
from
e044eaf to
3ae96f6
Compare
Signed-off-by: Sukhvansh2004 <[email protected]>
Signed-off-by: Sukhvansh2004 <[email protected]>
|
Hi @fujitatomoya , my PR is complete and is ready for review. Let me know if any more changes are required. Thanks! |
fujitatomoya
requested changes
Jan 14, 2025
| @@ -108,7 +108,7 @@ def send_goal(action_name, action_type, goal_values, feedback_callback): | |||
| goal = action_module.Goal() | |||
|
|
|||
| try: | |||
| set_message_fields(goal, goal_dict) | |||
| set_message_fields(goal, goal_dict, expand_header_auto=True, expand_time_now=True) | |||
There was a problem hiding this comment.
i do not think this works, actually this does not change anything.
this method only returns setter functions, those setter functions need to be called to set the values to the field before sending goal request or service request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have made services and actions consistent with topics as mentioned in the issue
closes #945