-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feetech_ros2_driver: 0.1.0-1 in 'rolling/distribution.yaml' [bloom] #43490
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New package review checklist
- At least one of the following must be present
- Top level license file:
- Per package license files:
- License is OSI-approved: BSD-3-Clause
- License correctly listed in package.xmls
- Public source repo: https://github.com/JafarAbdi/feetech_ros2_driver
- Source repository contains ROS packages
- Each package meets REP-144 naming conventions
Left a comment to consider and will wait for secondary approval from @sloretz before we merge this.
release: | ||
tags: | ||
release: release/rolling/{package}/{version} | ||
url: https://github.com/JafarAbdi/feetech_ros2_driver-release.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to consider housing the release repo in the ros2-gbp org instead? The advantage there is that your package will automatically be available in the next ROS 2 distribution on release day.
https://docs.ros.org/en/rolling/How-To-Guides/Releasing/First-Time-Release.html#create-a-new-release-repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For rolling
packages, the release repository must be housed in the ros2-gbp
organization.
Increasing version of package(s) in repository
feetech_ros2_driver
to0.1.0-1
:rolling/distribution.yaml
0.12.0
null
feetech_ros2_driver