Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feetech_ros2_driver: 0.1.0-1 in 'humble/distribution.yaml' [bloom] #43488

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JafarAbdi
Copy link
Contributor

Increasing version of package(s) in repository feetech_ros2_driver to 0.1.0-1:

feetech_ros2_driver

* Add feetech ros2 driver
* Contributors: Jafar Uruç

@github-actions github-actions bot added the humble Issue/PR is for the ROS 2 Humble distribution label Nov 13, 2024
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • At least one of the following must be present
    • Top level license file:
    • Per package license files
  • License is OSI-approved:
  • License correctly listed in package.xmls
  • Public source repo:
  • Source repository contains ROS packages
  • Each package meets REP-144 naming conventions - A package name should not contain ros as it is redundant. Exceptions include core packages and ROS bindings of an upstream library (e.g. moveit_ros)". According to REP-11 the package name should not include ros2, but as this is a driver for ros2_control I think it should be an exception. I'll wait for another reviewer weigh in.
Package name details
$ find . -name "package.xml" -exec grep --color=auto -e "<name>" "{}" ";"
  <name>feetech_ros2_driver</name>
License details
$ find . -name "package.xml" -exec grep --color=auto -e "<license[^>]*>" "{}" "+"
  <license>BSD</license>

@clalancette
Copy link
Contributor

See the comment in #43490 (review) , which will probably necessitate changes here.

@clalancette clalancette added the more information needed Maintainers have asked for additional information label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
humble Issue/PR is for the ROS 2 Humble distribution more information needed Maintainers have asked for additional information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants