Add openni_description package. #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
130s
force-pushed
the
i/add_description/add_openni_launch
branch
from
17059d8 to
8540628
Compare
… modification made yet.
130s
force-pushed
the
i/add_description/add_openni_launch
branch
2 times, most recently
from
04f133d to
bba958f
Compare
130s
commented
Jan 13, 2018
| resulted_urdf_file_relpath = "./sample_kobuki.urdf" | ||
| kobuki_xacro_file_path = rospkg.RosPack().get_path('openni_description') + "/test/sample_kobuki.urdf.xacro" | ||
| self.assertTrue(os.path.isfile(kobuki_xacro_file_path) | ||
| xacro_output_memory = xacro.process_file(kobuki_xacro_file_path) |
There was a problem hiding this comment.
This method is only available after xacro 1.10.x that is available after ROS Jade as of today.
130s
force-pushed
the
i/add_description/add_openni_launch
branch
6 times, most recently
from
5b310be to
0d8e849
Compare
[description][test] Use source permission to pass the tests in install space.
…rom xacro becomes available. [desc][test] I think xacro Python API is not meant to be used from outside of xacro pkg. [ci] Disable tests on Indigo as tests in openni_description might never pass on Indigo due to xacro issue.
130s
force-pushed
the
i/add_description/add_openni_launch
branch
from
0d8e849 to
c58566e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realizing the suggestion in this discourse thread. Kinect's model file is copied from turtlebot_description and removed Turtlebot-specific portion.
In a trial to show what's changed from Turtlebot version, I separate commits as much as possible.
This PR depends on #57-> Rebased.