Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation on ros2_control_node and make lock_memory false by default #1890

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Add documentation on ros2_control_node and make lock_memory false by default #1890

merged 1 commit into from
Nov 27, 2024

Conversation

saikishor
Copy link
Member

firesurfer
firesurfer approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@firesurfer firesurfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

christophfroehlich
christophfroehlich approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
related to #1821, but the change to the getting started page is still needed

@bmagyar bmagyar merged commit abb4c68 into ros-controls:master Nov 27, 2024
21 checks passed
@saikishor saikishor deleted the fix/lock_memory branch November 27, 2024 17:16
@saikishor saikishor added the backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. label Nov 28, 2024
mergify bot pushed a commit that referenced this pull request Nov 28, 2024
@saikishor @mergify
Add documentation on ros2_control_node and make lock_memory false b…
193bdac 
…y default (#1890)

(cherry picked from commit abb4c68)

# Conflicts:
#	controller_manager/src/ros2_control_node.cpp
@mergify mergify bot mentioned this pull request Nov 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firesurfer firesurfer firesurfer approved these changes

@bmagyar bmagyar bmagyar approved these changes

@christophfroehlich christophfroehlich christophfroehlich approved these changes

@anfemosa anfemosa Awaiting requested review from anfemosa

@destogl destogl Awaiting requested review from destogl

@erickisos erickisos Awaiting requested review from erickisos

@homalozoa homalozoa Awaiting requested review from homalozoa

@peterdavidfagan peterdavidfagan Awaiting requested review from peterdavidfagan

@rosterloh rosterloh Awaiting requested review from rosterloh

Assignees
No one assigned
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saikishor @christophfroehlich @bmagyar @firesurfer