-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stuck passive joints #237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. I tested this with the pendulum from #172, it is working again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any plans to port this to gz_ros_control
? If you don't have time, I can do it
https://github.com/Mergifyio backport humble |
✅ Backports have been created
|
(cherry picked from commit 5dba0f9)
(cherry picked from commit 5dba0f9) Co-authored-by: Johannes Huemer <[email protected]>
I will have to set up / convert an example with passive joint for gz_sim, but I can do that. |
As mentioned in #235 and #219, a problem with passive joints was introduced by the following code line:
gazebo_ros2_control/gazebo_ros2_control/src/gazebo_system.cpp
Lines 597 to 600 in 0dc19ab
As suggested by @destogl, I added a vector with flags which indicates if a joint is active (has command interfaces) or passive and subsequently sets the velocity to zero or not.