Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passive joints are broken #219

Closed
christophfroehlich opened this issue Aug 11, 2023 · 4 comments
Closed

Passive joints are broken #219

christophfroehlich opened this issue Aug 11, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@christophfroehlich
Copy link
Contributor

christophfroehlich commented Aug 11, 2023

As a consequence of #177 , passive joints don't work any more (try #172).

The joint is now fixed, even if no command interface is defined.

@christophfroehlich christophfroehlich added the bug Something isn't working label Aug 11, 2023
christophfroehlich added a commit to christophfroehlich/gazebo_ros2_control that referenced this issue Aug 11, 2023
@christophfroehlich
Copy link
Contributor Author

christophfroehlich commented Aug 11, 2023

@AndyZe is this fallback which you introduced really needed?

// Fallback case is a velocity command of zero
this->dataPtr->sim_joints_[j]->SetVelocity(0, 0.0);

Deleting it fixes passive joints again, see c043d80

@bmagyar
Copy link
Member

bmagyar commented Aug 12, 2023

That PR was fairly old I think when we merged it, it's not too surprising something wasn't fully aligned.

@bmagyar
Copy link
Member

bmagyar commented Aug 12, 2023

I'll make myself a reminder note to never merge wildly unscoped PRs in the future ;)

@christophfroehlich
Copy link
Contributor Author

fixed with #237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants