Optimize moveos_stdlib::table #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pause125
requested review from
jolestar,
baichuan3,
templexxx,
wow-sven and
stevenlaw123
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jolestar
reviewed
Oct 4, 2023
| @@ -34,6 +34,9 @@ pub trait StateResolver { | |||
| cursor: Option<Vec<u8>>, | |||
| limit: usize, | |||
| ) -> Result<Vec<Option<ListState>>, anyhow::Error>; | |||
|
|
|||
| /// Resolve the table size if the handle is a table. | |||
| fn resolve_size(&self, handle: &ObjectID) -> Result<u64, anyhow::Error>; | |||
There was a problem hiding this comment.
We do not need a resolve_size in the StateResolver trait. We can use resolve_state(GLOBAL_OBJECT_STORAGE_HANDLE, table_handle) -> State(TableInfo) to replace it.
We also can refactor this later. Maybe the StateResolver need to be refactor to:
pub trait StateResolver {
// get object data from global state tree.
fn resolve_object(&self, object: &ObjectID) -> Result<Option<Object>, anyhow::Error>;
fn resolve_table(&self, handle: &ObjectID, key: &[u8]) -> Result<Option<State>, anyhow::Error>;There was a problem hiding this comment.
I recorded an issue. Refactoring StateResolver may relate too many places, I will check that later.
Comment on lines
133
to
135
| native fun destroy_empty_box_unchecked(table_handle: &ObjectID); | ||
|
|
||
| native fun drop_unchecked_box(table_handle: &ObjectID); |
There was a problem hiding this comment.
Merge the drop_unchecked_box and destroy_empty_box_unchecked?
jolestar
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary