Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor StateResolver to distinguish Object and Table #909

Closed
pause125 opened this issue Oct 4, 2023 · 0 comments · Fixed by #913
Closed

Refactor StateResolver to distinguish Object and Table #909

pause125 opened this issue Oct 4, 2023 · 0 comments · Fixed by #913
Assignees
Milestone

Comments

@pause125
Copy link
Collaborator

pause125 commented Oct 4, 2023

Maybe the StateResolver need to be refactor to:

pub trait StateResolver {
  // get object data from global state tree.
  fn resolve_object(&self, object: &ObjectID) -> Result<Option<Object>, anyhow::Error>;
  fn resolve_table(&self, handle: &ObjectID, key: &[u8]) -> Result<Option<State>, anyhow::Error>;

Originally posted by @jolestar in #908 (comment)

@pause125 pause125 self-assigned this Oct 4, 2023
@jolestar jolestar added this to the Rooch v0.2.1 milestone Oct 4, 2023
@github-project-automation github-project-automation bot moved this to Done in Rooch Oct 4, 2023
@jolestar jolestar modified the milestones: Rooch v0.2.1, Rooch v0.2 Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants