Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devel xsens rebased #19

Merged
merged 16 commits into from
Jun 4, 2019
Merged

Conversation

kouroshD
Copy link
Collaborator

As we discussed yesterday, I open this PR to merge my working activities from my fork to our shared repo on devel branch.
I have cleaned also the codes, and updated the application and config files.

@kouroshD kouroshD added the enhancement New feature or request label May 17, 2019
@kouroshD kouroshD requested a review from GiulioRomualdi May 17, 2019 00:28
@kouroshD kouroshD mentioned this pull request May 17, 2019
@kouroshD
Copy link
Collaborator Author

Since the code has been rebased, I would suggest we test it once before merging.

Copy link
Member

@GiulioRomualdi GiulioRomualdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove CMakeLists.txt.user, I think it is generated by QTCreator

app/robots/iCubGazeboV2_5/wholeBodyRetargeting.ini Outdated Show resolved Hide resolved
app/robots/iCubGenova04/wholeBodyRetargeting.ini Outdated Show resolved Hide resolved
app/scripts/dcmWalkingRetargetingVirtualizerXsens.xml Outdated Show resolved Hide resolved
app/scripts/dcmWalkingRetargetingVirtualizerXsens.xml Outdated Show resolved Hide resolved
app/scripts/dcmWalkingRetargetingXsens.xml Outdated Show resolved Hide resolved
}

// m_tick =std::chrono::duration_cast< std::chrono::milliseconds
// >(std::chrono::system_clock::now().time_since_epoch()); m_tock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to use a time profiler you can use the one in walking-controllers. Actually there are several utilities in walking-controllers that can be used in different scenarios (e.g. Time-profiler, Utilities library ). Probably we should find a way (e.g. move them in an other repo) to expose these libraries. @traversaro

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can either move them in a different repo, or start installing some of the code contained in walking-controllers as libraries (that may be convenenient if we eventually implement robotology/walking-controllers#30 ).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we have it, we may go for adding it to retargeting if we need to have it.

modules/Xsens_module/src/XsensRetargeting.cpp Outdated Show resolved Hide resolved
modules/Xsens_module/src/main.cpp Outdated Show resolved Hide resolved
modules/Xsens_module/src/XsensRetargeting.cpp Outdated Show resolved Hide resolved
modules/Xsens_module/src/XsensRetargeting.cpp Outdated Show resolved Hide resolved
@GiulioRomualdi
Copy link
Member

Let me know if you want to clean the history. Otherwise, I'll merge the PR.

@kouroshD kouroshD force-pushed the devel_Xsens_rebased branch from 1c888ca to 5ece81c Compare June 4, 2019 13:04
@kouroshD
Copy link
Collaborator Author

kouroshD commented Jun 4, 2019

Let me know if you want to clean the history. Otherwise, I'll merge the PR.

Done! Thank you.

@GiulioRomualdi
Copy link
Member

Merge!

@GiulioRomualdi GiulioRomualdi merged commit 04e3520 into robotology:devel Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants