Control the fingers and the walking through the OpenXR joystick #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inherited from the branch refactoring_and_htc_rebased
…if the button associated to the motion is pressed
- The buttons mask does not require the mask in conf file to have the same dimension of the number of buttons. - The module can start even if the connection to the fingers fails. Also, there will not be continuous errors printed. - Removed the internal state machine - Added possibility to print buttons and axes - The number of buttons is retrieved only once
Added "swapped" maps to control the walking.
This is to make it easier to trigger commands that require combination of buttons
Removed the dependencies from the RobotStateProvider to allow starting even when not using iFeel
S-Dafarra
force-pushed
the
JoypadFingersModule_rebased
branch
from
96e1193 to
e7bc3d6
Compare
|
Updated the license after #132 The PR is ready for review @GiulioRomualdi |
|
Friendly ping @GiulioRomualdi |
Another friendly ping. This would allow moving forward in #133 |
GiulioRomualdi
approved these changes
Oct 16, 2023
Comment on lines
+181
to
+189
| yarp::os::Bottle remoteControlBoards; | ||
| remoteControlBoards.clear(); | ||
| yarp::os::Bottle& remoteControlBoardsList = remoteControlBoards.addList(); | ||
| for (auto& iCubPart : iCubParts) | ||
| remoteControlBoardsList.addString("/" + robot + "/" + iCubPart); | ||
|
|
||
| options.put("remoteControlBoards", remoteControlBoards.get(0)); | ||
| options.put("localPortPrefix", "/" + name + "/remoteControlBoard"); | ||
| yarp::os::Property& remoteControlBoardsOpts = options.addGroup("REMOTE_CONTROLBOARD_OPTIONS"); |
There was a problem hiding this comment.
Not now but we may think of using blf in the future
There was a problem hiding this comment.
This is indeed a good point. TBH I copied some old existing code and I did not invest too much time on it. I have opened #134 as a reminder
Explicitly using parenthesis in for loops Co-authored-by: Giulio Romualdi <[email protected]>
|
CI passed. Merging. Thanks @GiulioRomualdi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes some code of https://github.com/robotology/walking-teleoperation/tree/refactoring_and_htc
The focus is only to control the walking and the fingers. There is some code duplication with the
OculusModule, but the plan in the future will be to deprecate that module.