-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LuGre friction model parameters added to ETH protocol #99
base: devel
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ale-git
We ought to increase the version number of the codebase with this new feature.
cc @marcoaccame
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ale-git:
- ok the change of version of icub-firmware-shared but also pls change in icub-main the minimum required version in here.
- the changes in files
EoProtocolMC*
are not necessary and can be reverted. they are required only if one wants to set the LuGre values separately from the set of the complete joint.
CMakeLists.txt
Outdated
@@ -6,7 +6,7 @@ | |||
cmake_minimum_required(VERSION 3.12) | |||
|
|||
project(icub_firmware_shared | |||
VERSION 1.40.0) | |||
VERSION 1.40.1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @ale-git, I have changed the icub_firmware_shared VERSION to be 1.40.1 so that we maintain 40 as a value of the iCub Software release and we use the final .1 to force icub-main to use this particular version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is fine. For merge, let's wait that the other linked PRs are ready
hi @pattacini, the versioning of icub-firmware-shared is now ok. will you pls mark it as solved? thanks. |
b6291a6
to
2d8001d
Compare
Added LuGre friction model for sensorless torque estimation. Built on - robotology/icub-firmware#527 - robotology/icub-firmware-shared#99
- LuGre configuration moved to motor configuration - version incremented
2d8001d
to
ab259c4
Compare
I've rebased and updated the version, ready for merge. |
Hi @marcoaccame |
The parameters for LuGre friction model used in torque sensorless estimation have been added to the ETH boards protocol.