Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LuGre friction model parameters added to ETH protocol #99

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from

Conversation

ale-git
Copy link
Contributor

@ale-git ale-git commented Oct 22, 2024

The parameters for LuGre friction model used in torque sensorless estimation have been added to the ETH boards protocol.

@ale-git ale-git requested a review from marcoaccame October 22, 2024 12:42
@ale-git ale-git self-assigned this Oct 22, 2024
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ale-git

We ought to increase the version number of the codebase with this new feature.

cc @marcoaccame

Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ale-git:

  • ok the change of version of icub-firmware-shared but also pls change in icub-main the minimum required version in here.
  • the changes in files EoProtocolMC* are not necessary and can be reverted. they are required only if one wants to set the LuGre values separately from the set of the complete joint.

CMakeLists.txt Outdated
@@ -6,7 +6,7 @@
cmake_minimum_required(VERSION 3.12)

project(icub_firmware_shared
VERSION 1.40.0)
VERSION 1.40.1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ale-git, I have changed the icub_firmware_shared VERSION to be 1.40.1 so that we maintain 40 as a value of the iCub Software release and we use the final .1 to force icub-main to use this particular version.

Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is fine. For merge, let's wait that the other linked PRs are ready

@marcoaccame
Copy link
Contributor

Hi @ale-git

We ought to increase the version number of the codebase with this new feature.

cc @marcoaccame

hi @pattacini, the versioning of icub-firmware-shared is now ok. will you pls mark it as solved? thanks.

ale-git added a commit to ale-git/icub-firmware-build that referenced this pull request Nov 19, 2024
Added LuGre friction model for sensorless torque estimation.

Built on
- robotology/icub-firmware#527
- robotology/icub-firmware-shared#99
@ale-git ale-git marked this pull request as ready for review November 20, 2024 09:57
@ale-git
Copy link
Contributor Author

ale-git commented Dec 24, 2024

I've rebased and updated the version, ready for merge.

ale-git added a commit to ale-git/icub-firmware-build that referenced this pull request Dec 24, 2024
@pattacini
Copy link
Member

Hi @marcoaccame
I would merge this PR today to unlock robotology/icub-main#989.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants