Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Macos CI to mamba #371

Merged
merged 11 commits into from
Oct 30, 2023
Merged

Change Macos CI to mamba #371

merged 11 commits into from
Oct 30, 2023

Conversation

lrapetti
Copy link
Member

As discussed in #354

@lrapetti lrapetti marked this pull request as draft October 24, 2023 13:03
@lrapetti lrapetti self-assigned this Oct 24, 2023
@lrapetti
Copy link
Member Author

CI is still failing since it is installing an old version of idyntree in MacOS CI.

This is what I see for MacOS (see here ):

Transaction
  
    Prefix: /Users/runner/micromamba/envs/human-dynamics-estimation
  
    Updating specs:
  
     - cmake
     - compilers
     - make
     - ninja
     - pkg-config
     - yarp
     - icub-main
     - wearables
     - idyntree
     - matio-cpp
     - robometry
     - osqp-eigen
  
  
    Package                               Version  Build                  Channel          Size
  ───────────────────────────────────────────────────────────────────────────────────────────────
    Install:
  ───────────────────────────────────────────────────────────────────────────────────────────────
  ...
    + idyntree                              5.3.0  py39hbafad0e_0         conda-forge       3MB

while on Windwos CI (see here ), we have the following

Transaction
  
    Prefix: C:\Users\runneradmin\micromamba\envs\human-dynamics-estimation
  
    Updating specs:
  
     - cmake
     - compilers
     - make
     - ninja
     - pkg-config
     - yarp
     - icub-main
     - wearables
     - idyntree
     - matio-cpp
     - robometry
     - osqp-eigen
  
  
    Package                                 Version  Build               Channel          Size
  ----------------------------------------------------------------------------------------------
    Install:
  ----------------------------------------------------------------------------------------------
  ...
+ idyntree                                8.1.0  py310h666c5ba_0     conda-forge       7MB

@lrapetti
Copy link
Member Author

@traversaro do you have any suggestion?

@lrapetti
Copy link
Member Author

lrapetti commented Oct 24, 2023

As suggested by @CarlottaSartore the problem could be related to channel priority. conda-forge channel should be used for iDynTree

@CarlottaSartore
Copy link

@lrapetti bt looking at the output you attached both OS download from 'conda-forges' so I do not think is due to outdated version in robotology super build channel

Copy link
Member

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the package on conda-forge is librobometry, not robometry

ci_env.yml Outdated Show resolved Hide resolved
@lrapetti
Copy link
Member Author

As suggested by @CarlottaSartore the problem could be related to channel priority. conda-forge channel should be used for iDynTree

You're right! Then the issue should be something else!

@lrapetti
Copy link
Member Author

The name of the package on conda-forge is librobometry, not robometry

Thanks I have changed it in af89f6f

@traversaro
Copy link
Member

The name of the package on conda-forge is librobometry, not robometry

Thanks I have changed it in af89f6f

To avoid this kind of issue in the future I opened conda-forge/librobometry-feedstock#13 .

@traversaro traversaro self-requested a review October 24, 2023 17:12
ci_env.yml Outdated Show resolved Hide resolved
Co-authored-by: Silvio Traversaro <[email protected]>
@traversaro
Copy link
Member

traversaro commented Oct 25, 2023

mac and win fail with:

-- Could NOT find Boost (missing: Boost_INCLUDE_DIR) 
CMake Warning at devices/HumanLogger/CMakeLists.txt:5 (find_package):
  Found package configuration file:

    C:/Users/runneradmin/micromamba/envs/human-dynamics-estimation/Library/lib/cmake/robometry/robometryConfig.cmake

  but it set robometry_FOUND to FALSE so package "robometry" is considered to
  be NOT FOUND.  Reason given by package:

  robometry could not be found because dependency Boost could not be found.



--  [x] Plugin: human_logger (ENABLE_human_logger)

I suspect this is a robometry regression, related to conda-forge/librobometry-feedstock#12 .

@lrapetti
Copy link
Member Author

mac and win fail with:

-- Could NOT find Boost (missing: Boost_INCLUDE_DIR) 
CMake Warning at devices/HumanLogger/CMakeLists.txt:5 (find_package):
  Found package configuration file:

    C:/Users/runneradmin/micromamba/envs/human-dynamics-estimation/Library/lib/cmake/robometry/robometryConfig.cmake

  but it set robometry_FOUND to FALSE so package "robometry" is considered to
  be NOT FOUND.  Reason given by package:

  robometry could not be found because dependency Boost could not be found.



--  [x] Plugin: human_logger (ENABLE_human_logger)

I suspect this is a robometry regression, related to conda-forge/librobometry-feedstock#12 .

This failure was not happening before the change in matio-cpp (2651f45)

@traversaro
Copy link
Member

This failure was not happening before the change in matio-cpp (2651f45)

Probably in that case by chance the boost packages were installed, and so it was working by chance.

@traversaro
Copy link
Member

This failure was not happening before the change in matio-cpp (2651f45)

I think this was happening as an old version of robometry was installed due to some dependency.

@traversaro
Copy link
Member

Sorry, this is still failing as I forgot to bump the build number in conda-forge/librobometry-feedstock#14, this will be fixed by conda-forge/librobometry-feedstock#15 .

@traversaro traversaro closed this Oct 29, 2023
@traversaro traversaro reopened this Oct 29, 2023
@lrapetti lrapetti marked this pull request as ready for review October 30, 2023 08:50
@lrapetti
Copy link
Member Author

CI is now working, thanks @traversaro, we can merge it!

@lrapetti lrapetti merged commit 4c1f0b8 into master Oct 30, 2023
7 of 9 checks passed
@lrapetti lrapetti deleted the macos-ci-to-mamba branch October 30, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants