Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test if robometry CMake package can be found correctly and fix boost dependency #14

Merged
merged 5 commits into from
Oct 25, 2023

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Oct 25, 2023

Fix regression in #12 . Furthermore, add a test to prevent further regressions in find_package(robometry REQUIRED) failures in the future using https://github.com/ami-iit/cmake-package-check .

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

traversaro commented Oct 25, 2023

The regression test we added indeed fails, as expected (reproducing the failure in robotology/human-dynamics-estimation#371):

+ cmake-package-check robometry
===================================
=== Generated CMakeLists.txt file: 
===================================
-- The CXX compiler identification is GNU 12.3.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: $PREFIX/bin/x86_64-conda-linux-gnu-cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: $PREFIX/bin/x86_64-conda-linux-gnu-c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at /home/conda/feedstock_root/build_artifacts/robometry-split_1698222493677/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Boost (missing: Boost_INCLUDE_DIR)
Call Stack (most recent call first):
  /home/conda/feedstock_root/build_artifacts/robometry-split_1698222493677/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  /home/conda/feedstock_root/build_artifacts/robometry-split_1698222493677/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/share/cmake-3.27/Modules/FindBoost.cmake:2392 (find_package_handle_standard_args)
  /home/conda/feedstock_root/build_artifacts/robometry-split_1698222493677/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/share/cmake-3.27/Modules/CMakeFindDependencyMacro.cmake:76 (find_package)
  /home/conda/feedstock_root/build_artifacts/robometry-split_1698222493677/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/cmake/robometry/robometryConfig.cmake:32 (find_dependency)
  CMakeLists.txt:5 (find_package)


-- Configuring incomplete, errors occurred!
Error occurred: Command '['cmake', '-GNinja', '-S.', '-B.']' returned non-zero exit status 1.
===================================
=== Result:
===================================
cmake-package-check: FAILURE.

@traversaro
Copy link
Contributor Author

The regression test we added indeed fails, as expected (reproducing the failure in robotology/human-dynamics-estimation#371):

This was fixed by adding the required dependencies.

@traversaro traversaro merged commit 18faa4f into conda-forge:main Oct 25, 2023
7 checks passed
@traversaro traversaro deleted the fixboostdep branch October 25, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant