-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split arg_lut, causes, csr, csr32 from constants.py #195
Conversation
3e901b5
to
58b5a26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this is an improvement, but I'd like @neelgala and others to weigh in before merging.
fb72b79
to
e267981
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #195 +/- ##
==========================================
- Coverage 93.58% 92.76% -0.82%
==========================================
Files 3 3
Lines 717 636 -81
==========================================
- Hits 671 590 -81
Misses 46 46
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
7abda06
to
950228e
Compare
Basically, the reason of this PR is I'm drafting a cleaner parser in Scala: https://github.com/sequencer/rvdecoderdb, which need to make all necessary information machine readable. I personally don't want to parse python script, thus move those these metadata into csv files. |
lgtm.. but you will need to resolve the conflicts to get this merged. |
950228e
to
03d59c5
Compare
@neelgala Fixed :) |
Can we get this in? |
No description provided.