Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split arg_lut, causes, csr, csr32 from constants.py #195

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

sequencer
Copy link
Contributor

No description provided.

Copy link
Member

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is an improvement, but I'd like @neelgala and others to weigh in before merging.

@sequencer sequencer force-pushed the constant_csv branch 3 times, most recently from fb72b79 to e267981 Compare September 24, 2023 11:14
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2023

Codecov Report

Merging #195 (03d59c5) into master (e6b3022) will decrease coverage by 0.82%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
- Coverage   93.58%   92.76%   -0.82%     
==========================================
  Files           3        3              
  Lines         717      636      -81     
==========================================
- Hits          671      590      -81     
  Misses         46       46              
Files Changed Coverage Δ
constants.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sequencer sequencer force-pushed the constant_csv branch 3 times, most recently from 7abda06 to 950228e Compare September 24, 2023 14:00
@sequencer
Copy link
Contributor Author

Basically, the reason of this PR is I'm drafting a cleaner parser in Scala: https://github.com/sequencer/rvdecoderdb, which need to make all necessary information machine readable. I personally don't want to parse python script, thus move those these metadata into csv files.

@neelgala
Copy link
Collaborator

lgtm.. but you will need to resolve the conflicts to get this merged.

@sequencer
Copy link
Contributor Author

@neelgala Fixed :)

@sequencer
Copy link
Contributor Author

Can we get this in?

@aswaterman aswaterman merged commit 09c6db5 into riscv:master Sep 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants