Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide description for measurement transcript usage. #126

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jyao1
Copy link
Collaborator

@jyao1 jyao1 commented Nov 28, 2024

No description provided.

@jyao1 jyao1 requested a review from sameo November 28, 2024 00:41
src/08-attestation.adoc Outdated Show resolved Hide resolved
src/08-attestation.adoc Outdated Show resolved Hide resolved
src/08-attestation.adoc Outdated Show resolved Hide resolved
Comment on lines 213 to 215
* The measurement record is protected by the digital signature.
There is no need to use other mechanism (such as TLS) to protect the
measurement record between the host and the remote verifier.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The measurement record is protected by the digital signature.
There is no need to use other mechanism (such as TLS) to protect the
measurement record between the host and the remote verifier.
* Measurement record integrity protection. The provided <<SPDM>> measurement transcript digital signature protects the measurement record integrity against:
* Transport attacks between the host and the remote verifier, that should otherwise be protected through TLS.
* Internal device attacks and vulnerabilities. The Device Security Manager (DSM) may be composed of several pieces of firmware, and every one of them can potentially forge the measurements before returning it to the requester. With a digitally signed measurement transcript, they can not be modified after the DSM RoT signs them, effectively removing all other DSM components out of the overall TCB.
* <<SPDM>> `MEASUREMENTS` response opaque data field addition. With a signed transcript, device-specific opaque data is included into the `MEASUREMENTS` response. This piece of data may be required by the device verifier.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

@@ -203,6 +203,34 @@ Although the device measurement and certificate are not required to be included
in the TVM report, the TVM should provide a mechanism to return the device
measurement and certificate for the verifier to perform further verification.

To support remote verification, the device measurement data shall the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To support remote verification, the device measurement data shall the
To support remote verification, the device measurement data shall be the

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants