generated from riscv/docs-spec-template
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide description for measurement transcript usage. #126
Open
jyao1
wants to merge
1
commit into
riscv-non-isa:main
Choose a base branch
from
jyao1:meas
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+28
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameo
reviewed
Dec 3, 2024
src/08-attestation.adoc
Outdated
Comment on lines
213
to
215
* The measurement record is protected by the digital signature. | ||
There is no need to use other mechanism (such as TLS) to protect the | ||
measurement record between the host and the remote verifier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
* The measurement record is protected by the digital signature. | |
There is no need to use other mechanism (such as TLS) to protect the | |
measurement record between the host and the remote verifier. | |
* Measurement record integrity protection. The provided <<SPDM>> measurement transcript digital signature protects the measurement record integrity against: | |
* Transport attacks between the host and the remote verifier, that should otherwise be protected through TLS. | |
* Internal device attacks and vulnerabilities. The Device Security Manager (DSM) may be composed of several pieces of firmware, and every one of them can potentially forge the measurements before returning it to the requester. With a digitally signed measurement transcript, they can not be modified after the DSM RoT signs them, effectively removing all other DSM components out of the overall TCB. | |
* <<SPDM>> `MEASUREMENTS` response opaque data field addition. With a signed transcript, device-specific opaque data is included into the `MEASUREMENTS` response. This piece of data may be required by the device verifier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed.
Signed-off-by: Jiewen Yao <[email protected]>
sameo
approved these changes
Dec 3, 2024
sameo
reviewed
Dec 3, 2024
@@ -203,6 +203,34 @@ Although the device measurement and certificate are not required to be included | |||
in the TVM report, the TVM should provide a mechanism to return the device | |||
measurement and certificate for the verifier to perform further verification. | |||
|
|||
To support remote verification, the device measurement data shall the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
To support remote verification, the device measurement data shall the | |
To support remote verification, the device measurement data shall be the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.