Support changing paths on the ingress

[UnstoppableMango]

This introduces a breaking change, if that is not preferred I have another branch with the same change in a non-breaking fashion.

Sorry for the PR spam 😅 I was happy to find a maintained chart for this

[ressu]

Whoops, I saw this after I had already merged the other fix. But I think I actually prefer this solution over the current option.

[UnstoppableMango]

You're good! I hadn't actually opened a PR for the alternative, it was just a branch in my fork. I've rebased to fix the merge conflict in the README!

[ressu]

I kind of want to merge this as is. But I keep thinking about backwards compatibility. A quick way to fix that would be to do a check in the template whether it's a string or array.

Honestly, I don't know if it's worth the effort though.

[UnstoppableMango]

I learned about kindIs today, I've updated the impl to use that to check for a string host. How does that look?

You're right, it probably wasn't worth the effort but I think it turned out pretty ok 😄

[ressu]

Looks good. Thanks!

[heliochronix]

I noticed this results in the deployment template setting ADVERTISE_IP to a map[] value rather than the actual FQDNs:

         - name: ADVERTISE_IP
           value: |
-            https://plex.domain.tld
-            ,https://plex.domain.tld:443
+            https://map[host:plex.domain.tld]
+            ,https://map[host:plex.domain.tld]:443

Is that okay or should the deployment.yaml template be fixed?

[UnstoppableMango]

That's probably not right, but I'm not 100% sure. I'll take a look. Sorry if I introduced a bug!

[UnstoppableMango]

Yep, I broke it. Working on a fix!

[ressu]

Oh right, the advertise ip gets adjusted based on the ingress address too. To be fair, the whole block could be simplified quite a bit as it's doing the same thing in 2 blocks.

kube-plex/charts/kube-plex/templates/deployment.yaml

Lines 141 to 155 in 561cbec

	{{- if (or (eq .Values.service.type "ClusterIP") (empty .Values.service.type)) }}
	- name: ADVERTISE_IP
	value: |
	{{ if .Values.ingress.hosts }}https://{{ join ",https://" .Values.ingress.hosts }}{{ end }}
	{{ if .Values.ingress.hosts }},https://{{ join ",https://" .Values.ingress.hosts }}:443{{ end }}
	{{- else if eq .Values.service.type "LoadBalancer" }}
	{{- if (or .Values.service.loadBalancerIP .Values.ingress.hosts (index .Values.service.annotations "dns.pfsense.org/hostname")) }}
	- name: ADVERTISE_IP
	value: |
	{{ if .Values.service.loadBalancerIP }}https://{{ .Values.service.loadBalancerIP }}:32400{{ end }}
	{{ if index .Values.service.annotations "dns.pfsense.org/hostname" }},https://{{ join ",https://" (splitList "," (index .Values.service.annotations "dns.pfsense.org/hostname")) }}:32400{{ end }}
	{{ if .Values.ingress.hosts }},https://{{ join ",https://" .Values.ingress.hosts }}{{ end }}
	{{ if .Values.ingress.hosts }},https://{{ join ",https://" .Values.ingress.hosts }}:443{{ end }}
	{{- end }}
	{{- end }}