Fix ADVERTISE_IP to work with structured ingress paths #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves ADVERTISE_IP logic to a helper function
Fixes the regression from #52
I believe this should have roughly equivalent output to the original.
Here are a few of the commands I tested with
helm template . --set 'ingress.enabled=true' --set 'ingress.hosts[0]=test.example.com' --set 'ingress.hosts[1]=test2.example.com'
helm template . --set 'ingress.enabled=true' --set 'ingress.hosts[0].host=test.example.com' --set 'ingress.hosts[1].host=test2.example.com'
I noticed that on
main
the first url doesn't seem to get a:443
variant and is duplicated instead. Was this intentional?Main renders:
This branch renders (whitespace added for readability):