Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra env to helm template #96

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Add extra env to helm template #96

merged 4 commits into from
Oct 5, 2023

Conversation

cbodonnell
Copy link
Contributor

PR from fork: #95

What this PR does / why we need it:

Provide the ability to add extra env variables to the replicated-sdk deployment.

Steps to reproduce

Add the following snippet to the helm value file.

extraEnv: 
  - name: TEST
    value: 123

Run helm template repli . --dry-run --debug -f values.yaml.tmpl and you should see the value added in the replicated-deployment env.

Does this PR introduce a user-facing change?

Adds support for adding additional environment variables to the replicated deployment via the `extraEnv` value.

Does this PR require documentation?

NONE

Utwo added 2 commits October 5, 2023 14:15
@Utwo
Add extra env to helm template
7a70877 
(cherry picked from commit fad9320)
@Utwo
Update chart/templates/replicated-deployment.yaml
841c6ba 
Co-authored-by: Craig O'Donnell <[email protected]>
(cherry picked from commit a45380d)
@cbodonnell cbodonnell changed the title Cbo/utwo/extra env Add extra env to helm template Oct 5, 2023
sgalsaleh
sgalsaleh previously approved these changes Oct 5, 2023
View reviewed changes
@cbodonnell cbodonnell requested a review from sgalsaleh October 5, 2023 18:22
@cbodonnell cbodonnell merged commit 41f67ae into main Oct 5, 2023
10 checks passed
@cbodonnell cbodonnell deleted the cbo/Utwo/extra-env branch October 5, 2023 18:51
This was referenced Oct 5, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgalsaleh sgalsaleh sgalsaleh approved these changes

Assignees
No one assigned
Labels
type::feature type::improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbodonnell @sgalsaleh @Utwo