Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra env to helm template #95

Closed
wants to merge 2 commits into from
Closed

Conversation

Utwo
Copy link
Contributor

@Utwo Utwo commented Oct 5, 2023

What this PR does / why we need it:

Provide the ability to add extra env variables to the replicated-sdk deployment.

Steps to reproduce

Add the following snippet to the helm value file.

extraEnv: 
  - name: TEST
    value: 123

Run helm template repli . --dry-run --debug -f values.yaml.tmpl and you should see the value added in the replicated-deployment env.

Does this PR introduce a user-facing change?

A new `extraEnv` attribute was added to the helm values.

Does this PR require documentation?

NONE

@cbodonnell
Copy link
Contributor

Thanks for the contribution, @Utwo! It looks like we may need to pull these changes into a branch to run our tests on them. I can do that and share the PR here.

@Utwo
Copy link
Contributor Author

Utwo commented Oct 5, 2023

Alright, thank you!

@cbodonnell
Copy link
Contributor

Alright, thank you!

#96 Is merged with these changes and will be available in the next release. Thanks again!

@cbodonnell cbodonnell closed this Oct 5, 2023
@Utwo
Copy link
Contributor Author

Utwo commented Oct 5, 2023

Nice! Do you know when the next release will be available?

@cbodonnell
Copy link
Contributor

Nice! Do you know when the next release will be available?

@Utwo I'll aim to get this released tomorrow for you and will keep you posted.

@Utwo
Copy link
Contributor Author

Utwo commented Oct 6, 2023

Monday is fine, no need to have this over the weekend.

@cbodonnell
Copy link
Contributor

cbodonnell commented Oct 6, 2023

@Utwo FYI - this one is available now in v1.0.0-beta.9. Let us know how it works out for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants