Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jon cancel withdraw request #29

Closed
wants to merge 7 commits into from
Closed

Jon cancel withdraw request #29

wants to merge 7 commits into from

Conversation

acuarica
Copy link
Contributor

Migrated from PR Ethernautas/renpool#51.

Even if they are merge conflicts, we need to review if we want to incorporate these changes.

Closes #7.

@acuarica acuarica requested a review from fede-rodes November 27, 2021 09:24
@acuarica acuarica mentioned this pull request Nov 27, 2021
Closed
@acuarica acuarica marked this pull request as draft November 27, 2021 09:41
fede-rodes
fede-rodes reviewed Nov 27, 2021
View reviewed changes
Copy link
Contributor

@fede-rodes fede-rodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should open a new PR for this and rethink the whole logic

@acuarica
Copy link
Contributor Author

Ok, closing this then.

@acuarica acuarica closed this Nov 28, 2021
@acuarica acuarica deleted the jon-cancelWithdrawRequest branch November 28, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fede-rodes fede-rodes fede-rodes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement cancelRequestWithdraw
3 participants
@acuarica @fede-rodes @JonathanStefanov