Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove project stale branches #1

Closed
acuarica opened this issue Nov 26, 2021 · 7 comments
Closed

Remove project stale branches #1

acuarica opened this issue Nov 26, 2021 · 7 comments
Assignees
Labels
refactor Improves project quality without added value
Milestone

Comments

@acuarica
Copy link
Contributor

acuarica commented Nov 26, 2021

The repo was configured to not Automatically delete head branches[1] after pull requests are merged.

Review current project branches to check whether they have become stale. If so, we should delete them.

List of all branches https://github.com/renpool/renpool-contracts/branches/all


[1] https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-the-automatic-deletion-of-branches

@acuarica acuarica added the refactor Improves project quality without added value label Nov 26, 2021
@acuarica acuarica changed the title Remove project stake branches Remove project stale branches Nov 27, 2021
@acuarica acuarica self-assigned this Nov 27, 2021
@acuarica
Copy link
Contributor Author

The following branches have no commits ahead of main. It should be safe to delete them.

rel/brownie
fea/ethersjs
fea/fe-tests

@acuarica
Copy link
Contributor Author

The branch cancelWithdrawRequest seems to be already included in #29. It should be safe to delete it.

@acuarica
Copy link
Contributor Author

The rest of the branches should have a corresponding PR.

@fede-rodes to keep in the loop.

@fede-rodes
Copy link
Contributor

We can remove all mentioned branches, in case of need we can have a look at the old repo

@acuarica
Copy link
Contributor Author

The mentioned branches

rel/brownie
fea/ethersjs
fea/fe-tests
cancelWithdrawRequest

were deleted.

@acuarica acuarica added this to the MVP milestone Nov 28, 2021
@acuarica
Copy link
Contributor Author

The only remaining branches coming from the old repo are

fea/56-fede
fea/fe-gateway

@fede-rodes what should we do with them?

@acuarica acuarica reopened this Nov 28, 2021
@acuarica
Copy link
Contributor Author

Branches were deleted, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improves project quality without added value
Projects
None yet
Development

No branches or pull requests

2 participants