Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pixi using PIXI_PROJECT_MANIFEST instead of the nearest pixi.toml during manifest discovery #36

Merged
merged 7 commits into from
Nov 29, 2024
Merged

Fix pixi using PIXI_PROJECT_MANIFEST instead of the nearest pixi.toml during manifest discovery #36

merged 7 commits into from
Nov 29, 2024

Conversation

renan-r-santos
Copy link
Owner

Fixes #35

@renan-r-santos
Remove PIXI_IN_SHELL from kernel env and use
70f1259 
that for running `pixi` verifications
@codecov Codecov
Copy link

codecov bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (054357f) to head (9c40656).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #36   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         4    +1     
  Lines           81        91   +10     
  Branches        12        12           
=========================================
+ Hits            81        91   +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aqc-carlodri
aqc-carlodri suggested changes Nov 29, 2024
View reviewed changes
Copy link

@aqc-carlodri aqc-carlodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some suggestions, but otherwise good for me! Thank you!

src/pixi_kernel/pixi.py Outdated Show resolved Hide resolved
src/pixi_kernel/pixi.py Outdated Show resolved Hide resolved
src/pixi_kernel/pixi.py Outdated Show resolved Hide resolved
@renan-r-santos
Better location for removing PIXI_IN_SHELL
cc215d2 
Rename pixi_on_pixi to pixi_in_pixi
Remove str() on subprocess.run calls
Use cwd.resolve instead ot csd.absolute
@renan-r-santos
Copy os.environ in tests
9c40656
@renan-r-santos renan-r-santos merged commit 59186c4 into main Nov 29, 2024
9 checks passed
@renan-r-santos renan-r-santos deleted the fix-pixi-on-pixi branch November 29, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aqc-carlodri aqc-carlodri aqc-carlodri requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uncorrect error of missing ipykernel in dependencies
2 participants
@renan-r-santos @aqc-carlodri