Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add topic resource missing methods #22

Merged
merged 7 commits into from
Feb 8, 2024
Merged

Feat: add topic resource missing methods #22

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
096d9b4
[feat] Add version, prod endpoint and override
r-vasquez Feb 5, 2024
dd457d8
[chore] update proto files
r-vasquez Feb 5, 2024
d480854
[bug] return error on token authentication failure
r-vasquez Feb 7, 2024
d8ad661
[bug] Do not remove resource from state in datasources
r-vasquez Feb 7, 2024
25497de
[chore] remove warning on empty provider data.
r-vasquez Feb 7, 2024
7a06df5
[bug] Fix wrong error message in user import
r-vasquez Feb 7, 2024
0731d07
[chore] implement missing topic resource methods
r-vasquez Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion redpanda/resources/user/resource_user.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ func (u *User) ImportState(ctx context.Context, req resource.ImportStateRequest,
ClientSecret: u.resData.ClientSecret,
})
if err != nil {
resp.Diagnostics.AddError("unable to start a cluster client", "unable to start a cluster client; make sure ADDR ID format is <user_name>:<cluster_id>")
resp.Diagnostics.AddError("unable to start a cluster client", "unable to start a cluster client; make sure ADDR ID format is <user_name>,<cluster_id>")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh dang nice catch, that would have burned someone bad

return
}
cluster, err := client.GetCluster(ctx, &cloudv1beta1.GetClusterRequest{
Expand Down