Feat: add topic resource missing methods #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we default to prod environment and created an env variable for dev overrides
This includes the changes to support Topic endpoints.
We were not failing even if the request returned a non-200 error code.
Does not make sense here, if the cluster is not there, that means that the user used a cluster ID that does not exist.
In the early configuration of the terraform lifecycle, the provider data is not set and is valid.
This includes: - Update - Import - Read There are a few workarounds commented in the code.
|
CI failure is: golangci/golangci-lint#4353 We can wait, or we can pin golangci-lint to a specific version |
| @@ -216,7 +216,7 @@ func (u *User) ImportState(ctx context.Context, req resource.ImportStateRequest, | |||
| ClientSecret: u.resData.ClientSecret, | |||
| }) | |||
| if err != nil { | |||
| resp.Diagnostics.AddError("unable to start a cluster client", "unable to start a cluster client; make sure ADDR ID format is <user_name>:<cluster_id>") | |||
| resp.Diagnostics.AddError("unable to start a cluster client", "unable to start a cluster client; make sure ADDR ID format is <user_name>,<cluster_id>") | |||
There was a problem hiding this comment.
oh dang nice catch, that would have burned someone bad
Comment on lines
+345
to
+347
| // cleanup.policy always report the source as Dynamic even if we are | ||
| // using the default. We can't manage this property for now. | ||
| // See https://github.com/redpanda-data/redpanda/issues/2225 |
There was a problem hiding this comment.
should we add a consistent label to these comments to make them easier to find when the fix is in?
gene-redpanda
approved these changes
Feb 7, 2024
|
Seeing all that topic struct work get deleted was painful 😢 but I'm honesty happier with the outcome so huzzah! |
andrewstucki
pushed a commit
to andrewstucki/terraform-provider-redpanda
that referenced
this pull request
Nov 22, 2024
Add Fedora 37 support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is best-reviewed commit by commit
We are now adding the production endpoint and the Dev Override environment variable to bypass this.
It also includes all the changes necessary to support the missing methods in the topic resource:
And it updates the proto files with the latest files + some small bug fixes.
Please note that some workarounds depend on other upstream changes. Also, we are missing tests that should come in a follow-up PR.