-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNF-13015: Add helper function to run lscpu
and parse result using regex parameters
#638
Merged
yarda
merged 2 commits into
redhat-performance:master
from
fontivan:sskeard/cnf-13015-cpu-architecture-vendor-detection-tuned
Jul 15, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
import re | ||
import tuned.logs | ||
from . import base | ||
|
||
log = tuned.logs.get() | ||
|
||
class lscpu_check(base.Function): | ||
""" | ||
Checks regexes against the output of lscpu. Accepts arguments in the | ||
following form: REGEX1, STR1, REGEX2, STR2, ...[, STR_FALLBACK] | ||
If REGEX1 matches something in the output it expands to STR1, | ||
if REGEX2 matches it expands to STR2. It stops on the first match, | ||
i.e. if REGEX1 matches, no more regexes are processed. If none | ||
regex matches it expands to STR_FALLBACK. If there is no fallback, | ||
it expands to empty string. | ||
""" | ||
def __init__(self): | ||
# unlimited number of arguments, min 2 arguments | ||
super(lscpu_check, self).__init__("lscpu_check", 0, 2) | ||
|
||
def execute(self, args): | ||
if not super(lscpu_check, self).execute(args): | ||
return None | ||
# Stdout is the 2nd result from the execute call | ||
_, lscpu = self._cmd.execute("lscpu") | ||
for i in range(0, len(args), 2): | ||
if i + 1 < len(args): | ||
if re.search(args[i], lscpu, re.MULTILINE): | ||
return args[i + 1] | ||
if len(args) % 2: | ||
return args[-1] | ||
else: | ||
return "" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could also check the return code here and potentially raise an exception though I'm not sure if its required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it maybe OK as it is. You should see the error output in the TuneD log and in case of error it will substitute empty string.