Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNF-13015: Add helper function to run lscpu and parse result using regex parameters #638

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions tuned/profiles/functions/function_lscpu_check.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import re
import tuned.logs
from . import base

log = tuned.logs.get()

class lscpu_check(base.Function):
"""
Checks regexes against the output of lscpu. Accepts arguments in the
following form: REGEX1, STR1, REGEX2, STR2, ...[, STR_FALLBACK]
If REGEX1 matches something in the output it expands to STR1,
if REGEX2 matches it expands to STR2. It stops on the first match,
i.e. if REGEX1 matches, no more regexes are processed. If none
regex matches it expands to STR_FALLBACK. If there is no fallback,
it expands to empty string.
"""
def __init__(self):
# unlimited number of arguments, min 2 arguments
super(lscpu_check, self).__init__("lscpu_check", 0, 2)

def execute(self, args):
if not super(lscpu_check, self).execute(args):
return None
# Stdout is the 2nd result from the execute call
_, lscpu = self._cmd.execute("lscpu")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could also check the return code here and potentially raise an exception though I'm not sure if its required

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it maybe OK as it is. You should see the error output in the TuneD log and in case of error it will substitute empty string.

for i in range(0, len(args), 2):
if i + 1 < len(args):
if re.search(args[i], lscpu, re.MULTILINE):
return args[i + 1]
if len(args) % 2:
return args[-1]
else:
return ""
Loading