CNF-13015: Add helper function to run lscpu and parse result using regex parameters
#638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fontivan
commented
Jun 10, 2024
fontivan
commented
- This is similar to the cpuinfo function that reads from /proc/cpuinfo
- Unfortunately that function was insufficient for our needs as we need to identify both the Vendor and Architecture reliably
…regex parameters - This is similar to the cpuinfo function that reads from /proc/cpuinfo - Unfortunately that function was insufficient for our needs as we need to identify both the Vendor and Architecture reliably
fontivan
changed the title
lscpu and parse result using egex parameterslscpu and parse result using regex parameters
fontivan
commented
Jun 13, 2024
| if not super(lscpu_check, self).execute(args): | ||
| return None | ||
| # Stdout is the 2nd result from the execute call | ||
| _, lscpu = self._cmd.execute("lscpu") |
There was a problem hiding this comment.
I could also check the return code here and potentially raise an exception though I'm not sure if its required
There was a problem hiding this comment.
I think it maybe OK as it is. You should see the error output in the TuneD log and in case of error it will substitute empty string.
|
Thanks, I think we can have this function. I am now @ DevConf, I will handle this during next week. |
|
@yarda any update for this? |
yarda
approved these changes
Jul 15, 2024
| if not super(lscpu_check, self).execute(args): | ||
| return None | ||
| # Stdout is the 2nd result from the execute call | ||
| _, lscpu = self._cmd.execute("lscpu") |
There was a problem hiding this comment.
I think it maybe OK as it is. You should see the error output in the TuneD log and in case of error it will substitute empty string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.