Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to latest sonobuoy and golang 1.21 #95

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Bump to latest sonobuoy and golang 1.21 #95

merged 3 commits into from
Mar 5, 2024

Conversation

jcpowermac
Copy link
Collaborator

This PR bumps sonobuoy to 0.57.1 and
switches to golang v1.21

@openshift-ci openshift-ci bot requested review from mtulio and rvanderp3 February 26, 2024 18:07
@jcpowermac
Copy link
Collaborator Author

Need to manually test this

@jcpowermac jcpowermac force-pushed the bump-sonobuoy branch 3 times, most recently from ddec207 to 53ceee9 Compare February 26, 2024 19:12
@jcpowermac
Copy link
Collaborator Author

This should be ready to go

Mon, 26 Feb 2024 19:20:23 CST> Global Status: post-processing                                                                                                                      
JOB_NAME                           | STATUS     | RESULTS    | PROGRESS                  | MESSAGE                                                                                 
05-openshift-cluster-upgrade       | complete   |            | 0/0 (0 failures)          | waiting for post-processor...                     
10-openshift-kube-conformance      | complete   |            | 384/390 (1 failures)      | waiting for post-processor...                                                           
20-openshift-conformance-validated | complete   |            | 3870/3879 (102 failures)  | waiting for post-processor...                                                           
99-openshift-artifacts-collector   | complete   |            | 0/0 (0 failures)          | waiting for post-processor...                                                           
INFO[2024-02-26T19:20:23-06:00] Waiting for post-processor...                                                                                                                      
Mon, 26 Feb 2024 19:27:23 CST> Global Status: complete                                                                                                                             
JOB_NAME                           | STATUS     | RESULTS    | PROGRESS                  | MESSAGE                                                                                 
05-openshift-cluster-upgrade       | complete   | passed     | 0/0 (0 failures)          | Total tests processed: 1 (1 pass / 0 failed)   

➜  vsphere-ipi ../opct-linux-amd64 retrieve
INFO[2024-02-27T06:16:19-06:00] Collecting results...                        
INFO[2024-02-27T06:16:33-06:00] Results saved to /home/jcallen/Development/before-installer-testing/vsphere-ipi/202402262142_sonobuoy_fd9c2eb3-e6ea-4c03-846b-b63d22ebb87d.tar.gz 
INFO[2024-02-27T06:16:33-06:00] Use the results command to check the validation test summary or share the results archive with your Red Hat partner.

@jcpowermac jcpowermac mentioned this pull request Feb 29, 2024
Closed
mtulio
mtulio reviewed Mar 4, 2024
View reviewed changes
Copy link
Contributor

@mtulio mtulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

Hey @jcpowermac , thanks for updating. Would you mind to run the opct report result.tar.gz command too? (we are missing some presubmits to validate it)

Feel free to drop the /hold when the report is validated. :)

Thanks!

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 4, 2024
@mtulio mtulio added kind/dependency-change Categorizes issue or PR as related to changing dependencies kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 4, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 5, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 5, 2024
@jcpowermac
Copy link
Collaborator Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2024
@mtulio
Copy link
Contributor

mtulio commented Mar 5, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtulio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f27f508 into redhat-openshift-ecosystem:main Mar 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtulio mtulio mtulio left review comments

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

Assignees

@mtulio mtulio

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcpowermac @mtulio @openshift-merge-robot