Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser rewrite #20

Merged
merged 32 commits into from
Dec 27, 2023
Merged

Parser rewrite #20

merged 32 commits into from
Dec 27, 2023

Conversation

jackdotink
Copy link
Member

@jackdotink jackdotink commented Dec 20, 2023 •
edited by sasial-dev
Loading

Closes #8
Closes #12

@jackdotink jackdotink added this to the 0.3 Release milestone Dec 20, 2023
@sasial-dev
Copy link
Collaborator

We've drawn out the new parser's file structure. For transperancy, here is a photo:
Brave Browser-tbutCVq5@2x

@sasial-dev sasial-dev marked this pull request as ready for review December 26, 2023 01:39
sasial-dev
sasial-dev requested changes Dec 26, 2023
View reviewed changes
Copy link
Collaborator

@sasial-dev sasial-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments:

cli/Cargo.toml Outdated Show resolved Hide resolved
zap/Cargo.toml Outdated Show resolved Hide resolved
zap/src/config.rs Outdated Show resolved Hide resolved
zap/src/config.rs Outdated Show resolved Hide resolved
cli/src/main.rs Outdated Show resolved Hide resolved
zap/src/lib.rs Outdated Show resolved Hide resolved
zap/src/parser/convert.rs Outdated Show resolved Hide resolved
zap/src/parser/convert.rs Outdated Show resolved Hide resolved
zap/src/parser/mod.rs Outdated Show resolved Hide resolved
zap/src/parser/mod.rs Outdated Show resolved Hide resolved
sasial-dev
sasial-dev reviewed Dec 26, 2023
View reviewed changes
cli/src/main.rs Outdated Show resolved Hide resolved
@jackdotink jackdotink linked an issue Dec 27, 2023 that may be closed by this pull request
[FEAT] Clarify output FS errors #24
Closed
@jackdotink @sasial-dev
lots of changes
6bbb2e3 
Co-authored-by: Sasial <[email protected]>
sasial-dev
sasial-dev requested changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@sasial-dev sasial-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments...

.vscode/launch.json Outdated Show resolved Hide resolved
cli/src/main.rs Show resolved Hide resolved
cli/src/main.rs Outdated Show resolved Hide resolved
zap/config.ebnf Outdated Show resolved Hide resolved
zap/config.ebnf Outdated Show resolved Hide resolved
zap/src/lib.rs Show resolved Hide resolved
zap/src/parser/reports.rs Outdated Show resolved Hide resolved
sasial-dev
sasial-dev approved these changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@sasial-dev sasial-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy.
There may be other issues down the line, but it's good enough for the beta release (aka 0.3.0 tomorrow imo).

@sasial-dev sasial-dev merged commit be79647 into main Dec 27, 2023
2 checks passed
@sasial-dev sasial-dev deleted the parser-rewrite branch December 27, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasial-dev sasial-dev sasial-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3 Release
2 participants
@jackdotink @sasial-dev