Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Clarify output FS errors #24

Closed
Crystalflxme opened this issue Dec 27, 2023 · 1 comment · Fixed by #20
Closed

[FEAT] Clarify output FS errors #24

Crystalflxme opened this issue Dec 27, 2023 · 1 comment · Fixed by #20
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Crystalflxme
Copy link

Describe your feature

While using the CLI, you can run into filesystem errors which don't clearly describe what the issue is.

These error messages should be more descriptive, pointing users to solutions. As a quality of life feature for output directories, any nonexistent directories should be created during execution.

Examples

For instance, a config that looks like this

opt output_client = ./network/client.luau
opt output_server = ./network/server.luau

...will cause the following generic and unclear filesystem error on Windows if no ./network directory exists:

Error: The system cannot find the path specified. (os error 3)

A similar error,

Error: The system cannot find the file specified. (os error 2)

...is output if the path provided to the config file is invalid.

Alternatives

Both of these are minor issues, so creating the directories in question and/or ensuring file paths are correct both work. The docs could also cover these common mistakes.

@Crystalflxme Crystalflxme added the enhancement New feature or request label Dec 27, 2023
@jackdotink jackdotink added this to the 0.3 Release milestone Dec 27, 2023
@jackdotink
Copy link
Member

This issue will be addressed in the 0.3 release.

@jackdotink jackdotink linked a pull request Dec 27, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants