-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add blink.cmp hlgroups (proceeds #263) #271
base: master
Are you sure you want to change the base?
Conversation
Changes suggested in rebelot#263 (review) - Prefer using links to Pmenu groups. - Added missing `CmpGhostText` group. - Removed some misplaced whitespaces. - Did NOT change ghost texts and deprecated items to `NonText` since it might be just my personal preference.
Thanks yes i would have fixed it today :). I opened it in November, since then Blink has changed drastically, thus my highlight groups are wrong now.
|
But yes especially the BlinkCmpItemKind => BlinkCmpKind things i just missed. Although i still use it and it looks fine :/ Thanks for correcting it anyway |
Oh, I should have been a bit more patient, just a few more hours.
I assume you couldn't notice the breaking change due to the fallback to nvim-cmp highlights option. This option is planned to be removed in the future, so we do need explicit blink.cmp highlights.
Seeing how many Neovim related projects stay in 0ver for years, I doubt waiting for the stabilization is a good idea. And having outdated highlights in the config doesn't do much harm other than wasting a few nanoseconds of startup time. I'd say it's better to have this merged now and update it as blink.cmp evolves. Also I don't think there will be much reason to change highlight names yet again (hopefully). I won't be having much time to spare this year. So if yet another breaking change happens to blink.cmp before this PR gets merged, please create a proceeding PR like I did. @jonsch318 |
I am largely finished with my thesis so i will have more time this year 👍 And yeah i will try to keep looking for breaking changes |
Adds highlight groups for
blink.cmp
.Fixed version of #263, which was using completely wrong highlight items.
Added support for ghost texts and label details as well.