feat: add blink.cmp hlgroups #263
Conversation
| BlinkCmpSignatureHelpBorder = { link = "FloatBorder" }, | ||
| BlinkCmpSignatureHelpActiveParameter = { link = "LspSignatureActiveParameter"}, | ||
|
|
||
| BlinkCmpItemKindText = { fg = theme.ui.fg }, |
There was a problem hiding this comment.
Should it be just BlinkCmpKind<kind> as it described in https://github.com/Saghen/blink.cmp/blob/main/docs/configuration/appearance.md ?
There was a problem hiding this comment.
Addressed in my PR^2
| BlinkCmpLabel = { fg = theme.ui.pmenu.fg }, | ||
| BlinkCmpLabelMatch = { fg = theme.syn.fun }, | ||
| BlinkCmpLabelDeprecated = { fg = theme.syn.comment, strikethrough = true }, | ||
| BlinkCmpGhostText = { fg = theme.syn.comment }, |
There was a problem hiding this comment.
I think it's better to use theme.ui.nontext for ghost texts to avoid confusion when typing inside comments. It's also the default highlight group blink.cmp chooses by default.
| BlinkCmpScrollBarGutter = {link = "PmenuSbar" }, | ||
| BlinkCmpLabel = { fg = theme.ui.pmenu.fg }, | ||
| BlinkCmpLabelMatch = { fg = theme.syn.fun }, | ||
| BlinkCmpLabelDeprecated = { fg = theme.syn.comment, strikethrough = true }, |
There was a problem hiding this comment.
The same goes for the deprecated items, blink uses NonText by default.
There was a problem hiding this comment.
Never mind this, just realized that using NonText for deprecated items makes it practically invisible on the default pmenu bg. I wasn't aware of this because I was using darker pmenu bg. But my point about the ghost text still stands.
There was a problem hiding this comment.
Most of the blink menu highlights are meant to be consistent with Pmenu* groups.
So { link = "Pmenu*" } or theme.ui.pmenu.* should be preferred if possible.
The end result is the same regardless of using links or directly accessing the palette.
But if the user (me, for example :P) happens to be customizing the theme through .setup(),
using links will properly propagate the changes to Pmenu* to plugin highlights.
There was a problem hiding this comment.
Just realized you mostly copied the nvim-cmp groups from below.
I think the same changes should be applied to cmp groups as well.
Guess I'll write a PR^2 to your PR, to avoid duplicate PRs on this main repo.
Changes suggested in rebelot#263 (review) - Prefer using links to Pmenu groups. - Added missing `CmpGhostText` group. - Removed some misplaced whitespaces. - Did NOT change ghost texts and deprecated items to `NonText` since it might be just my personal preference.
| BlinkCmpItemKindText = { fg = theme.ui.fg }, | ||
| BlinkCmpItemKindMethod = { link = "@function.method" }, | ||
| BlinkCmpItemKindFunction = { link = "Function" }, | ||
| BlinkCmpItemKindConstructor = { link = "@constructor" }, | ||
| BlinkCmpItemKindField = { link = "@variable.member" }, | ||
| BlinkCmpItemKindVariable = { fg = theme.ui.fg_dim }, | ||
| BlinkCmpItemKindClass = { link = "Type" }, | ||
| BlinkCmpItemKindInterface = { link = "Type" }, | ||
| BlinkCmpItemKindModule = { link = "@module" }, | ||
| BlinkCmpItemKindProperty = { link = "@property" }, | ||
| BlinkCmpItemKindUnit = { link = "Number" }, | ||
| BlinkCmpItemKindValue = { link = "String" }, | ||
| BlinkCmpItemKindEnum = { link = "Type" }, | ||
| BlinkCmpItemKindKeyword = { link = "Keyword" }, | ||
| BlinkCmpItemKindSnippet = { link = "Special" }, | ||
| BlinkCmpItemKindColor = { link = "Special" }, | ||
| BlinkCmpItemKindFile = { link = "Directory" }, | ||
| BlinkCmpItemKindReference = { link = "Special" }, | ||
| BlinkCmpItemKindFolder = { link = "Directory" }, | ||
| BlinkCmpItemKindEnumMember = { link = "Constant" }, | ||
| BlinkCmpItemKindConstant = { link = "Constant" }, | ||
| BlinkCmpItemKindStruct = { link = "Type" }, | ||
| BlinkCmpItemKindEvent = { link = "Type" }, | ||
| BlinkCmpItemKindOperator = { link = "Operator" }, | ||
| BlinkCmpItemKindTypeParameter = { link = "Type" }, | ||
| BlinkCmpItemKindCopilot = { link = "String" }, |
There was a problem hiding this comment.
Have you not tested your PR at all?
blink.cmp uses BlinkCmpKind*, not BlinkCmpItemKind*.
I was so confused what was going on with item highlights not applying...
Changes suggested in rebelot#263 (review) - Prefer using links to Pmenu groups. - Added missing `CmpGhostText` group. - Removed some misplaced whitespaces. - Did NOT change ghost texts and deprecated items to `NonText` since it might be just my personal preference.
feat: add blink.cmp hlgroups (proceeds #263)
Nothing should really change, since blink already reads most of these from pmenu per default. However explicitly defining this is better in my opinion. I orientated myself on the existing Cmp groups.