models: add new pending state #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audrium
force-pushed
the
366-new-pending-state
branch
from
a04309b to
e3b45b9
Compare
audrium
force-pushed
the
366-new-pending-state
branch
from
e3b45b9 to
4c7a369
Compare
setup.py
Outdated
| @@ -41,7 +41,7 @@ | |||
| install_requires = [ | |||
| "alembic>=1.4.2", | |||
| "psycopg2-binary>=2.6.1", | |||
| "SQLAlchemy>=1.2.7", | |||
| "SQLAlchemy>=1.2.7,<1.4.0", | |||
There was a problem hiding this comment.
Perhaps we can isolate the pinning on Python 2.7 only since latest sqlalchemy-utils contains a fix:
Suggested change
| "SQLAlchemy>=1.2.7,<1.4.0", | |
| + 'SQLAlchemy>=1.2.7 ; python_version>="3"', | |
| + 'SQLAlchemy>=1.2.7,<1.4 ; python_version>="2.7"', |
Note: we still have Python 2 in REANA-DB because we need it to run tests on R-Commons, which should support Python 2.7 since it is a dependency of REANA-Client.
audrium
force-pushed
the
366-new-pending-state
branch
from
4c7a369 to
2950c0c
Compare
diegodelemos
approved these changes
Apr 27, 2021
audrium
force-pushed
the
366-new-pending-state
branch
from
af84ed6 to
8b74668
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes reanahub/reana-workflow-controller#363